Add details parameter to get_vt_iterator() #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If details is True, it adds the vt dependencies as subelement with the oid. For this an expensive query to redis is necessary. The query takes about 3 seconds, which is especially expensive when only one vt must be sent. Otherwise, the dependencies are added as subelement of custom, the query will not be perfomed, and quicker response is given for a single vt.
|
It needs a Pipfile.lock update, after greenbone/ospd#222 is merged |
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
==========================================
+ Coverage 76.12% 76.14% +0.01%
==========================================
Files 6 6
Lines 1332 1333 +1
==========================================
+ Hits 1014 1015 +1
Misses 318 318
Continue to review full report at Codecov.
|
bjoernricks
approved these changes
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If details is True, it adds the vt dependencies as subelement
with the oid. For this an expensive query to redis is necessary.
The query takes about 3 seconds, which is especially expensive when
only one vt must be sent.
Otherwise, the dependencies are added as subelement of custom, the query
will not be perfomed, and quicker response is given for a single vt.
Depends on PR greenbone/ospd#222