Add missing scanner params #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## ospd-openvas-20.08 #293 +/- ##
======================================================
- Coverage 82.71% 81.86% -0.85%
======================================================
Files 9 9
Lines 1481 1511 +30
======================================================
+ Hits 1225 1237 +12
- Misses 256 274 +18
Continue to review full report at Codecov.
|
cfi-gb
suggested changes
Jul 18, 2020
CHANGELOG.md
Outdated
| @@ -22,6 +22,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/). | |||
| managing the version information in ospd-openvas [#238](https://github.com/greenbone/ospd-openvas/pull/238) | |||
| - Pass store directory to OSPDaemon init [#266](https://github.com/greenbone/ospd-openvas/pull/266) | |||
| - Add URI field to results for file path or webservice URL [#271](https://github.com/greenbone/ospd-openvas/pull/271) | |||
| - Add elemtn to OSPD_PARAMS entries to indicate visiblitiy for client. [#293](https://github.com/greenbone/ospd-openvas/pull/293) | |||
There was a problem hiding this comment.
Suggested change
| - Add elemtn to OSPD_PARAMS entries to indicate visiblitiy for client. [#293](https://github.com/greenbone/ospd-openvas/pull/293) | |
| - Add an element to OSPD_PARAMS entries to indicate visibility for client. [#293](https://github.com/greenbone/ospd-openvas/pull/293) |
ospd_openvas/daemon.py
Outdated
| 'mandatory': 0, | ||
| 'visible_for_client': 0, | ||
| 'description': ( | ||
| 'Is maximum number of hosts to test at the same time which' |
There was a problem hiding this comment.
Suggested change
| 'Is maximum number of hosts to test at the same time which' | |
| 'The maximum number of hosts to test at the same time which' |
ospd_openvas/daemon.py
Outdated
| 'description': ( | ||
| 'Is maximum number of hosts to test at the same time which' | ||
| + 'should be given to the client (which can override it).' | ||
| + 'This value must be computed given your bandwidth,' |
There was a problem hiding this comment.
Suggested change
| + 'This value must be computed given your bandwidth,' | |
| + 'This value must be computed given your bandwidth,' |
ospd_openvas/daemon.py
Outdated
| + 'should be given to the client (which can override it).' | ||
| + 'This value must be computed given your bandwidth,' | ||
| + 'the number of hosts you want to test, your amount of' | ||
| + 'memory and the horsepower of your processor(s).' |
There was a problem hiding this comment.
Suggested change
| + 'memory and the horsepower of your processor(s).' | |
| + ' memory and the performance of your processor(s).' |
ospd_openvas/daemon.py
Outdated
| 'Is maximum number of hosts to test at the same time which' | ||
| + 'should be given to the client (which can override it).' | ||
| + 'This value must be computed given your bandwidth,' | ||
| + 'the number of hosts you want to test, your amount of' |
There was a problem hiding this comment.
Suggested change
| + 'the number of hosts you want to test, your amount of' | |
| + ' the number of hosts you want to test, your amount of' |
ospd_openvas/daemon.py
Outdated
| 'visible_for_client': 0, | ||
| 'description': ( | ||
| 'Is maximum number of hosts to test at the same time which' | ||
| + 'should be given to the client (which can override it).' |
There was a problem hiding this comment.
Suggested change
| + 'should be given to the client (which can override it).' | |
| + ' should be given to the client (which can override it).' |
ospd_openvas/daemon.py
Outdated
| 'description': ( | ||
| 'Is maximum number of hosts to test at the same time which' | ||
| + 'should be given to the client (which can override it).' | ||
| + 'This value must be computed given your bandwidth,' |
There was a problem hiding this comment.
Suggested change
| + 'This value must be computed given your bandwidth,' | |
| + ' This value must be computed given your bandwidth,' |
ospd_openvas/daemon.py
Outdated
| 'mandatory': 0, | ||
| 'visible_for_client': 0, | ||
| 'description': ( | ||
| 'is the number of plugins that will run against each host being' |
There was a problem hiding this comment.
Suggested change
| 'is the number of plugins that will run against each host being' | |
| 'The number of plugins that will run against each host being' |
ospd_openvas/daemon.py
Outdated
| 'visible_for_client': 0, | ||
| 'description': ( | ||
| 'Name of the network interface that will be used as the source ' | ||
| + 'of connections established by OpenVAS. The scan won\'t be ' |
There was a problem hiding this comment.
Suggested change
| + 'of connections established by OpenVAS. The scan won\'t be ' | |
| + 'of connections established by openvas. The scan won\'t be ' |
As an alternative update the other occurrences of openvas to use OpenVAS
ArnoStiefvater
force-pushed
the
scanner-params
branch
3 times, most recently
from
e5b72aa
to
6e5eb50
Compare
jjnicola
previously approved these changes
Jul 21, 2020
drop_privileges preference should only be settable via openvas config file.
Support all openvas settings which are not strict openvas only settings.
We may run into problems on openvas side otherwise. For example adding the empty string for the ifaces_allow option would basically mean that we do not allow any iface.
ArnoStiefvater
force-pushed
the
scanner-params
branch
from
0701433
to
306fcd2
Compare
jjnicola
approved these changes
Jul 24, 2020
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Improve logger.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openvasscanner parameters which are notopenvasonly parameters.drop_privilegesfrom params dict.Related PR:
greenbone/ospd#301