Consider individually supplied alive test methods #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnoStiefvater
force-pushed
the
alive-test-xml
branch
from
c83eeed
to
f5ebfb2
Compare
2 tasks
|
@ArnoStiefvater what about this PR? |
This PR will be updated and marked for review soon. |
Alive test methods can now be specified not only via bit flag but also via single xml elements for evert method. This commit allows the use of these single elements.
Transform the specified alive test methods into a bit field as used in most of the gvm components via a seperate function.
Use fallback icmp ping method for boreas if no valid method was provided.
Alive test methods are supplied via seperate
elements. E.g.
<alive_test_methods>
<icmp>1</icmp>
<arp>1</arp>
</alive_test_methods>
ArnoStiefvater
force-pushed
the
alive-test-xml
branch
from
f5ebfb2
to
53c2504
Compare
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 84.16% 84.39% +0.23%
==========================================
Files 9 9
Lines 1471 1493 +22
==========================================
+ Hits 1238 1260 +22
Misses 233 233
Continue to review full report at Codecov.
|
Handle the case when the alive test was supplied via seperate elements. Also fix traceback when no valid alive test was supplied by checking if alive_test_opt is empty before trying to add them to the preferences.
Add test for invalid alive test. Add test for alive test supplied via seperete elements. Add test for empty alive test elements.
jjnicola
approved these changes
Oct 14, 2020
ArnoStiefvater
pushed a commit
to ArnoStiefvater/ospd-openvas
that referenced
this pull request
Oct 25, 2021
Changed dependabot schedule to weekly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Alive test methods can now be specified not only via bit field but also via single xml elements for every method. This PR allows the use of these single elements.
Alive test supplied via <alive_test> takes precedence over alive test methods supplied vi <alive_test_methods> element.
PR also fixes stack trace when invalid alive test is supplied.
Dependend on:
greenbone/ospd#329
Why:
Better usability.
How:
Tested with python-gvm and following target description with different configurations.
Checklist: