Fix container image builds #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openvas-scanner:unstable doesn't exist or is outdated. Edge contains the lastest openvas-scanner image built from the main branch.
With Debian 12 (bookworm) it isn't possible to use pip to install Python packages system wide because auf [PEP 668](https://peps.python.org/pep-0668). Therefore it requires the `--break-system-packages` switch or to use a virtual environment.
This code has been generalized into an own action.
The `semver` type of the docker meta-action only works with real semantic versions. Otherwise the tag will be ignored for the semver type.
When creating releases the container image should be build from the lastest stable openvas-scanner image. Otherwise the edge image should be used to check if the image still builds.
nichtsfrei
force-pushed
the
fix-container-image-builds
branch
from
22e80cd
to
0ba346f
Compare
When using pip it is not as easy as previously to use system packages. Therefore only pip is used.
nichtsfrei
force-pushed
the
fix-container-image-builds
branch
from
0ba346f
to
9f39d02
Compare
nichtsfrei
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fix container image build
Why
Necessary changes for Debian 12 and to use the correct openvas-scanner base image.
References
https://github.com/greenbone/ospd-openvas/actions/runs/5505323711