Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix container image builds #913

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Fix container image builds #913

merged 6 commits into from
Jul 10, 2023

Conversation

bjoernricks
Copy link
Contributor

What

Fix container image build

Why

Necessary changes for Debian 12 and to use the correct openvas-scanner base image.

References

https://github.com/greenbone/ospd-openvas/actions/runs/5505323711

openvas-scanner:unstable doesn't exist or is outdated. Edge contains the
lastest openvas-scanner image built from the main branch.
With Debian 12 (bookworm) it isn't possible to use pip to install Python
packages system wide because auf [PEP 668](https://peps.python.org/pep-0668).
Therefore it requires the `--break-system-packages` switch or to use a
virtual environment.
This code has been generalized into an own action.
The `semver` type of the docker meta-action only works with real
semantic versions. Otherwise the tag will be ignored for the semver
type.
When creating releases the container image should be build from the
lastest stable openvas-scanner image. Otherwise the edge image should be
used to check if the image still builds.
@bjoernricks bjoernricks requested review from a team as code owners July 10, 2023 09:13
@bjoernricks bjoernricks enabled auto-merge (rebase) July 10, 2023 09:14
@nichtsfrei nichtsfrei disabled auto-merge July 10, 2023 09:26
@nichtsfrei nichtsfrei enabled auto-merge (rebase) July 10, 2023 09:31
When using pip it is not as easy as previously to
use system packages. Therefore only pip is used.
@nichtsfrei nichtsfrei merged commit b2c9977 into main Jul 10, 2023
@nichtsfrei nichtsfrei deleted the fix-container-image-builds branch July 10, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants