Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add hostname attribute to results #108

Merged
merged 5 commits into from
Jun 3, 2019
Merged

Conversation

jjnicola
Copy link
Member

No description provided.

@jjnicola jjnicola requested review from timopollmeier and a team May 29, 2019 14:25
@codecov
Copy link

codecov bot commented May 29, 2019

Codecov Report

Merging #108 into master will increase coverage by 0.5%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #108     +/-   ##
=========================================
+ Coverage   68.07%   68.58%   +0.5%     
=========================================
  Files           8        8             
  Lines        1604     1595      -9     
=========================================
+ Hits         1092     1094      +2     
+ Misses        512      501     -11
Impacted Files Coverage Δ
ospd/xml.py 100% <ø> (ø) ⬆️
ospd/misc.py 70.58% <81.81%> (+0.65%) ⬆️
ospd/ospd.py 66.54% <0%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ca130...9ac2aca. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #108 into master will increase coverage by 0.09%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   68.07%   68.17%   +0.09%     
==========================================
  Files           8        8              
  Lines        1604     1615      +11     
==========================================
+ Hits         1092     1101       +9     
- Misses        512      514       +2
Impacted Files Coverage Δ
ospd/xml.py 100% <ø> (ø) ⬆️
ospd/misc.py 70.15% <81.81%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ca130...9ac2aca. Read the comment docs.

@codecov
Copy link

codecov bot commented May 31, 2019

Codecov Report

Merging #108 into master will increase coverage by 0.09%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   68.19%   68.29%   +0.09%     
==========================================
  Files           8        8              
  Lines        1610     1621      +11     
==========================================
+ Hits         1098     1107       +9     
- Misses        512      514       +2
Impacted Files Coverage Δ
ospd/xml.py 100% <ø> (ø) ⬆️
ospd/ospd.py 66.07% <71.42%> (ø) ⬆️
ospd/misc.py 70.3% <83.33%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b01902...d9ff879. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes May 31, 2019
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit

@jjnicola jjnicola merged commit 8082e9c into greenbone:master Jun 3, 2019
@jjnicola jjnicola deleted the hostname branch October 8, 2019 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants