This repository has been archived by the owner on Nov 29, 2021. It is now read-only.
Refactor misc #111
Merged
Refactor misc #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
+ Coverage 68.48% 69.96% +1.47%
==========================================
Files 8 10 +2
Lines 1631 1588 -43
==========================================
- Hits 1117 1111 -6
+ Misses 514 477 -37
Continue to review full report at Codecov.
|
Move network related function from misc to new network module.
Our own versions aren't needed anymore because they have been added for windows support. The python socket library has windows support since python 3.4 See https://docs.python.org/3.5/library/socket.html#socket.inet_pton and https://docs.python.org/3.5/library/socket.html#socket.inet_ntop
Start to use typings for functions in network module. This will help to gather expected behavior and to implement tests.
Move the cli parser related functions from misc into a new parser module.
Move main and print_version functions from misc module into a new main module. Rewrite print_version to support file output.
Include the wrapper name into the logging output. This will allow to remove the wrapper_logging code.
All modules should use an independent logger now.
jjnicola
previously approved these changes
Jun 21, 2019
SysLogHandler and WatchedFiledHandler need to be imported from logging.handlers module.
jjnicola
approved these changes
Jun 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.