Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add dummy stop_scan method to be implemented in the wrapper. #24

Merged
merged 1 commit into from
Jun 26, 2018

Conversation

jjnicola
Copy link
Member

No description provided.

@jjnicola jjnicola requested review from janowagner and a team June 26, 2018 07:34
@codecov
Copy link

codecov bot commented Jun 26, 2018

Codecov Report

Merging #24 into master will increase coverage by 3.32%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
+ Coverage   55.72%   59.04%   +3.32%     
==========================================
  Files           4        4              
  Lines        1048     1050       +2     
==========================================
+ Hits          584      620      +36     
+ Misses        464      430      -34
Impacted Files Coverage Δ
ospd/ospd.py 64.63% <100%> (+2.92%) ⬆️
ospd/misc.py 54.18% <0%> (+4.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5099f8f...59a8468. Read the comment docs.

@jjnicola jjnicola changed the title Add dummy close_scan method to be implemented in the wrapper. Add dummy stop_scan method to be implemented in the wrapper. Jun 26, 2018
janowagner
janowagner previously approved these changes Jun 26, 2018
Copy link
Member

@janowagner janowagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change as such is OK.
But I recommend to add a test in tests/testScanAndResult.py calling the command <stop_scan ... >.

Add test testScanAndResult.py calling <stop_scan... >
Copy link
Member

@janowagner janowagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codacy issue not relevant to me because it
is internal tests. But in general we should make XML parsing secure.

@janowagner janowagner merged commit a8e77a1 into greenbone:master Jun 26, 2018
@jjnicola jjnicola deleted the stop-scan branch June 27, 2018 06:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants