Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add support for credentials in multi-target mode. #41

Merged
merged 2 commits into from
Sep 3, 2018

Conversation

jjnicola
Copy link
Member

Credentials in multi-target mode are a subelement of each element.
It also considers the legacy modes, which receive the username and password as
scan_options.

@jjnicola jjnicola requested review from kroosec, wiegandm, janowagner and a team August 31, 2018 10:09
@codecov
Copy link

codecov bot commented Aug 31, 2018

Codecov Report

Merging #41 into master will increase coverage by 0.61%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   63.75%   64.36%   +0.61%     
==========================================
  Files           4        4              
  Lines        1123     1131       +8     
==========================================
+ Hits          716      728      +12     
+ Misses        407      403       -4
Impacted Files Coverage Δ
ospd/ospd_ssh.py 88.37% <100%> (+11.22%) ⬆️
ospd/ospd.py 68.86% <0%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f12eaa5...2282224. Read the comment docs.

Credentials in multi-target mode are a subelement of each <target> element.
It also considers the legacy modes, which receive the username and password as
scan_options.
Add unit tests.
@jjnicola jjnicola merged commit 5cd1773 into greenbone:master Sep 3, 2018
@jjnicola jjnicola deleted the ospd-ssh-cred branch September 3, 2018 07:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants