Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

Add option for logging into a specified log file. #98

Merged
merged 3 commits into from
Mar 27, 2019

Conversation

jjnicola
Copy link
Member

No description provided.

@jjnicola jjnicola requested review from bjoernricks and a team March 27, 2019 13:44
@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #98 into master will decrease coverage by 0.13%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   66.95%   66.82%   -0.14%     
==========================================
  Files           8        8              
  Lines        1513     1519       +6     
==========================================
+ Hits         1013     1015       +2     
- Misses        500      504       +4
Impacted Files Coverage Δ
ospd/misc.py 66.22% <37.5%> (-0.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa47dab...315b37e. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 27, 2019

Codecov Report

Merging #98 into master will decrease coverage by 0.17%.
The diff coverage is 30.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   66.95%   66.77%   -0.18%     
==========================================
  Files           8        8              
  Lines        1513     1517       +4     
==========================================
  Hits         1013     1013              
- Misses        500      504       +4
Impacted Files Coverage Δ
ospd/misc.py 66.09% <30.76%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa47dab...a56ef78. Read the comment docs.

bjoernricks
bjoernricks previously approved these changes Mar 27, 2019
Remove the background and syslog facilities, because they are the default ones.
Add the foreground option.
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a spelling mistake. I've added a suggestion.

ospd/misc.py Outdated Show resolved Hide resolved
Co-Authored-By: jjnicola <jjnicola@gmail.com>
@jjnicola jjnicola merged commit 43c50b6 into greenbone:master Mar 27, 2019
@jjnicola jjnicola deleted the log2file branch March 27, 2019 14:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants