Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor methods edits requested in review #1021

Merged
merged 11 commits into from Sep 9, 2021
Merged

Minor methods edits requested in review #1021

merged 11 commits into from Sep 9, 2021

Conversation

rando2
Copy link
Collaborator

@rando2 rando2 commented Aug 31, 2021 •
edited

Description of the proposed additions or changes

This PR addresses the following:

  • 1.2

Outstanding questions:

  • 1.2: I am not quite sure where the reviewer is getting that link from. I added a link to the pdf everywhere we linked the .html build, but I'd be interested to know whether anyone has an idea what I link they are suggesting we fix!

Related issues

Suggested reviewers (optional)

Checklist

  • Text is formatted so that each sentence is on its own line.
  • Pre-prints cited in this pull request have a GitHub issue opened so that they can be reviewed.

@rando2 rando2 marked this pull request as draft August 31, 2021 15:40
@rando2 rando2 mentioned this pull request Aug 31, 2021
Closed
28 tasks
@AppVeyorBot
Copy link

AppVeyor build 1.0.4364 for commit 09f8114 is now complete.

Found 2 potential spelling error(s). Preview:content/23.vaccines-app.md:15:IgGs
content/23.vaccines-app.md:387:IgGs...
The rendered manuscript from this build is temporarily available for download at:

@rando2 rando2 added the Methods Strategies for review label Sep 1, 2021
@AppVeyorBot
Copy link

AppVeyor build 1.0.4377 for commit e8c1756 is now complete.

Found 4 potential spelling error(s). Preview:content/22.vaccines.md:21:devleopment
content/22.vaccines.md:74:appraoches
content/23.vaccines-app.md:15:IgGs
content/23.vaccines-app.md:387:IgGs...
The rendered manuscript from this build is temporarily available for download at:

@agitter
Copy link
Collaborator

agitter commented Sep 2, 2021

Perhaps the reviewer was browsing the GitHub repository, saw the output directory, and expected the rendered outputs to be there. It is a confusing setup because that directory is essentially an empty template for Manubot and the contents only appear in the output branch. We also have some errors there that I'll fix.

We have the badge in the main readme with the PDF link, but that may not be obvious enough.

I pushed cd447ac, which (hopefully) adds a link to the versioned PDF to the front matter. That will make the PDF easier to find and also partial address comment 1.1 if the HTML is not responsive.

@AppVeyorBot
Copy link

AppVeyor build 1.0.4382 for commit cd447ac is now complete.

Found 4 potential spelling error(s). Preview:content/22.vaccines.md:21:devleopment
content/22.vaccines.md:74:appraoches
content/23.vaccines-app.md:15:IgGs
content/23.vaccines-app.md:387:IgGs...
The rendered manuscript from this build is temporarily available for download at:

@AppVeyorBot
Copy link

AppVeyor build 1.0.4422 for commit ca9d03b is now complete.

Found 4 potential spelling error(s). Preview:content/22.vaccines.md:21:devleopment
content/22.vaccines.md:74:appraoches
content/23.vaccines-app.md:15:IgGs
content/23.vaccines-app.md:387:IgGs...
The rendered manuscript from this build is temporarily available for download at:

@rando2 rando2 marked this pull request as ready for review September 9, 2021 15:18
@rando2 rando2 changed the title Minor methods edits requested in review (draft) Minor methods edits requested in review Sep 9, 2021
@rando2
Copy link
Collaborator Author

rando2 commented Sep 9, 2021

Planning to merge this in & make a pass on more substantial changes on a new branch

@AppVeyorBot
Copy link

AppVeyor build 1.0.4442 for commit 1b7de74 is now complete.

Found 5 potential spelling error(s). Preview:content/22.vaccines.md:21:devleopment
content/22.vaccines.md:74:appraoches
content/22.vaccines.md:127:passaging
content/23.vaccines-app.md:15:IgGs
content/23.vaccines-app.md:387:IgGs...
The rendered manuscript from this build is temporarily available for download at:

@rando2 rando2 merged commit 2bcf287 into greenelab:master Sep 9, 2021
@rando2 rando2 deleted the methods-edits-minor branch September 9, 2021 17:06
github-actions bot pushed a commit that referenced this pull request Sep 9, 2021
@rando2
Merge pull request #1021 from rando2/methods-edits-minor
44c898a 
[ci skip]

This build is based on
2bcf287.

This commit was created by the following CI build and job:
https://github.com/greenelab/covid19-review/commit/2bcf287241085c340b0346af1b798cd9c84ac113/checks
https://github.com/greenelab/covid19-review/runs/1218210096
github-actions bot pushed a commit that referenced this pull request Sep 9, 2021
@rando2
Merge pull request #1021 from rando2/methods-edits-minor
22dc00b 
[ci skip]

This build is based on
2bcf287.

This commit was created by the following CI build and job:
https://github.com/greenelab/covid19-review/commit/2bcf287241085c340b0346af1b798cd9c84ac113/checks
https://github.com/greenelab/covid19-review/runs/1218210096
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agitter agitter agitter approved these changes

Assignees
No one assigned
Labels
Merge Pending Checks Methods Strategies for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rando2 @AppVeyorBot @agitter