-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proofread traditional vaccines #1195
Conversation
AppVeyor build 1.0.5336 for commit f0f27c9 is now complete. Found 1 potential spelling error(s). Preview:content/22.vaccines-trad.md:501:granma... |
AppVeyor build 1.0.5338 for commit 1b15c83 is now complete. Found 0 potential spelling error(s). Preview:... |
@rando2 I finished my proofreading and this is ready for review. Please note the line that needs two citations because I wasn't sure what to add. I want to check the latest artifact to confirm my update to the citation of the Manubot version of the manuscript correctly includes the latest authors. Hopefully it's not too late to send this updated version to the journal (and include my COI from #1193). |
AppVeyor build 1.0.5340 for commit 9da98b6 is now complete. Found 0 potential spelling error(s). Preview:... |
My fixes in #1196 and #1197 worked and Figure 4 now shows up. I reran the GitHub Actions build and the artifacts there contain the updated artifacts with the figure: I had also updated the manual reference for the Manubot version of the manuscript we use for the online appendix to include the newest authors:
|
AppVeyor build 1.0.5342 for commit 6558e67 is now complete. Found 0 potential spelling error(s). Preview:... |
AppVeyor build 1.0.5343 for commit bfa9195 is now complete. Found 0 potential spelling error(s). Preview:... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are great suggestions, @agitter! Thank you so much! I'll resubmit today.
AppVeyor build 1.0.5346 for commit 4c61ce0 failed. |
[ci skip] This build is based on 87675d2. This commit was created by the following CI build and job: https://github.com/greenelab/covid19-review/commit/87675d2caf1c5febc06c0eec4a252df3bc7fae88/checks https://github.com/greenelab/covid19-review/actions/runs/3932130117
[ci skip] This build is based on 87675d2. This commit was created by the following CI build and job: https://github.com/greenelab/covid19-review/commit/87675d2caf1c5febc06c0eec4a252df3bc7fae88/checks https://github.com/greenelab/covid19-review/actions/runs/3932130117
Thanks! I'll tag v2 of the traditional vaccines manuscript because we should have all the edits now. Do we want to submit this updated version to arXiv? |
@agitter Hold off on v2 for a few minutes-- I have a couple of super minor edits made while prepping submission. I can tag you on that PR once everything is final. |
@rando2 sorry, I was already doing it locally and missed this I can make a comment on the release about the commits that were actually part of the resubmission or I can tag with 2.1. |
Sorry @agitter! It probably isn't a big deal at all -- it's nearly identical, just slight differences in the abstract and then we had lost a table reference somehow. |
It only takes a minute or two to tag, so I'm okay making v2.1 tags that match what goes to the journal. This time I'll wait until you give me the okay 😄 |
Work in progress. I'll finish later today.