Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proofread traditional vaccines #1195

Merged
merged 10 commits into from
Jan 16, 2023
Merged

Conversation

agitter
Copy link
Collaborator

@agitter agitter commented Jan 13, 2023

Work in progress. I'll finish later today.

@AppVeyorBot
Copy link

AppVeyor build 1.0.5336 for commit f0f27c9 is now complete.

Found 1 potential spelling error(s). Preview:content/22.vaccines-trad.md:501:granma...
The rendered manuscript from this build is temporarily available for download at:

@AppVeyorBot
Copy link

AppVeyor build 1.0.5338 for commit 1b15c83 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

@agitter agitter marked this pull request as ready for review January 13, 2023 23:11
content/22.vaccines-trad.md Outdated Show resolved Hide resolved
@agitter
Copy link
Collaborator Author

agitter commented Jan 13, 2023

@rando2 I finished my proofreading and this is ready for review. Please note the line that needs two citations because I wasn't sure what to add.

I want to check the latest artifact to confirm my update to the citation of the Manubot version of the manuscript correctly includes the latest authors.

Hopefully it's not too late to send this updated version to the journal (and include my COI from #1193).

@AppVeyorBot
Copy link

AppVeyor build 1.0.5340 for commit 9da98b6 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

@agitter
Copy link
Collaborator Author

agitter commented Jan 14, 2023

My fixes in #1196 and #1197 worked and Figure 4 now shows up. I reran the GitHub Actions build and the artifacts there contain the updated artifacts with the figure:
image

I had also updated the manual reference for the Manubot version of the manuscript we use for the online appendix to include the newest authors:
image

literal authors aren't being treated correctly though so we get "Medicine II of the IS of" and "Consortium CR". I'm not sure why, because they work for the evolution section of the manuscript.

@AppVeyorBot
Copy link

AppVeyor build 1.0.5342 for commit 6558e67 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

@AppVeyorBot
Copy link

AppVeyor build 1.0.5343 for commit bfa9195 is now complete.

Found 0 potential spelling error(s). Preview:...
The rendered manuscript from this build is temporarily available for download at:

@agitter
Copy link
Collaborator Author

agitter commented Jan 14, 2023

The literal authors are working now. The manual reference id wasn't correct:
image

Copy link
Collaborator

@rando2 rando2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are great suggestions, @agitter! Thank you so much! I'll resubmit today.

content/22.vaccines-trad.md Outdated Show resolved Hide resolved
@AppVeyorBot
Copy link

AppVeyor build 1.0.5346 for commit 4c61ce0 failed.

@rando2 rando2 merged commit 87675d2 into greenelab:master Jan 16, 2023
@agitter agitter deleted the proofread-trad-vaccines branch January 16, 2023 19:15
@agitter
Copy link
Collaborator Author

agitter commented Jan 16, 2023

I'll resubmit today.

Thanks! I'll tag v2 of the traditional vaccines manuscript because we should have all the edits now.

Do we want to submit this updated version to arXiv?

@rando2
Copy link
Collaborator

rando2 commented Jan 16, 2023

@agitter Hold off on v2 for a few minutes-- I have a couple of super minor edits made while prepping submission. I can tag you on that PR once everything is final.

@agitter
Copy link
Collaborator Author

agitter commented Jan 16, 2023

@rando2 sorry, I was already doing it locally and missed this

I can make a comment on the release about the commits that were actually part of the resubmission or I can tag with 2.1.

@rando2
Copy link
Collaborator

rando2 commented Jan 16, 2023

Sorry @agitter! It probably isn't a big deal at all -- it's nearly identical, just slight differences in the abstract and then we had lost a table reference somehow.

@agitter
Copy link
Collaborator Author

agitter commented Jan 16, 2023

It only takes a minute or two to tag, so I'm okay making v2.1 tags that match what goes to the journal. This time I'll wait until you give me the okay 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants