Remove empty date-parts in issued #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What we used to do: Note this won't work anymore, since now date-parts is empty rather than being |
dhimmel
force-pushed
the
empty-date-parts
branch
from
4b481ff
to
09e2da2
Compare
dhimmel
force-pushed
the
empty-date-parts
branch
from
09e2da2
to
42abf18
Compare
add additional tests _remove_error: handle required validation errors
dhimmel
force-pushed
the
empty-date-parts
branch
from
5e037c3
to
9ad8fa3
Compare
|
As of 9ad8fa3, Note that issued is now an empty object, but does not get entirely removed: |
agitter
reviewed
Oct 21, 2018
Thanks agitter for spotting this
dhimmel
force-pushed
the
empty-date-parts
branch
from
4428dad
to
dfda71c
Compare
agitter
approved these changes
Oct 23, 2018
dhimmel
added a commit
that referenced
this pull request
Oct 23, 2018
Merges #65 Fixes empty issued date-parts bug reported in the following issues: - Closes #66 - Closes #75 - Fixes greenelab/meta-review#101 (comment) Recursively remove errors in remove_jsonschema_errors. Combined with a CSL JSON schema that specifies minItems for date-parts, this change fixes the above issues. See citation-style-language/schema#158 for the CSL JSON schema changes that are intended to be present in the CSL schema loaded by this package. Tests removal of empty date-parts for issued object.
dhimmel
added a commit
that referenced
this pull request
Oct 23, 2018
Merges #65 Fixes empty issued date-parts bug reported in the following issues: - Closes #66 - Closes #75 - Fixes greenelab/meta-review#101 (comment) Recursively remove errors in remove_jsonschema_errors. Combined with a CSL JSON schema that specifies minItems for date-parts, this change fixes the above issues. See citation-style-language/schema#158 for the CSL JSON schema changes that are intended to be present in the CSL schema loaded by this package. Tests removal of empty date-parts for issued object.
|
I forgot to change the JSON Schema URL back, so I amended the merged commit in master. The new commit that this has been merged via is 4e6a0f6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: before merging, update manubot branch of dhimmel/csl-stylesdone in dhimmel/csl-schema@df3d1a3See greenelab/meta-review#101 (comment)
Refs #66