Support raw citations #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhimmel
force-pushed
the
raw-citations
branch
from
98d0cd4
to
ceab6aa
Compare
agitter
approved these changes
Oct 23, 2018
manubot/process/util.py
Outdated
| @@ -268,6 +270,12 @@ def generate_csl_items(args, citation_df): | |||
| if citation in manual_refs: | |||
| csl_items.append(manual_refs[citation]) | |||
| continue | |||
| elif citation.startswith('raw:'): | |||
| logging.error( | |||
| f'CSL JSON data with a standard_citation of {citation} not found in manual-references.json. ' | |||
There was a problem hiding this comment.
data has been capitalized in other instances of CSL JSON Data.
dhimmel
commented
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #62
TODO:
manubot cite. Done, opened Cite command error handling #77 to create more succinct error messages heremanual-references.json