Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbnail #37

Merged
merged 2 commits into from Nov 4, 2021
Merged

Add thumbnail #37

merged 2 commits into from Nov 4, 2021

Conversation

jjc2718
Copy link
Member

@jjc2718 jjc2718 commented Nov 3, 2021

As requested in: manubot/catalog#56 (comment)

@jjc2718 jjc2718 requested a review from ben-heil November 3, 2021 15:50
@ben-heil
Copy link

ben-heil commented Nov 3, 2021

LGTM, is there a way to preview the manubot build to make sure the thumbnail works like you want?

@jjc2718
Copy link
Member Author

jjc2718 commented Nov 3, 2021

Just realized Manubot has some guidelines for making a thumbnail - I'll update mine this afternoon and edit the PR.

LGTM, is there a way to preview the manubot build to make sure the thumbnail works like you want?

Good question, I'm not sure. Maybe @vincerubinetti would know?

@vincerubinetti
Copy link
Contributor

I believe the thumbnail is only used for the catalog. I don't think we ever hooked it up to anything else, like using it for the favicon. That is, it won't appear anywhere in your manuscript.

If you want to see how it looks in the catalog, here's a very crude preview:

image

@vincerubinetti
Copy link
Contributor

vincerubinetti commented Nov 3, 2021

Looked through your manuscript and here's my suggestion for a thumbnail, though ideally higher res from svg/powerpoint source. Or perhaps without the cancer cells in frame.

image

@jjc2718 jjc2718 merged commit 015e2a5 into greenelab:main Nov 4, 2021
@jjc2718 jjc2718 deleted the thumbnail branch November 9, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants