Incorrect dependency prefix after upgrade #85
Comments
This was referenced Nov 20, 2017
|
We had the same issue, greenkeeper added |
|
greenkeeper added |
feedmypixel
added a commit
to uktrade/data-hub-frontend
that referenced
this issue
Jan 3, 2018
What should be "get-form-data@^2.0.0:" in yarn.lock ends up being "get-form-data@2.0.0:". Essentially the prefix gets stripped when the dependancy gets added to yarn.lock Details in greenkeeperio/greenkeeper-lockfile#85 This commit updates the yarn.lock file to contain the caret
feedmypixel
added a commit
to uktrade/data-hub-frontend
that referenced
this issue
Jan 3, 2018
What should be "get-form-data@^2.0.0:" in yarn.lock ends up being "get-form-data@2.0.0:". Essentially the prefix gets stripped when the dependancy gets updated by greenkeeper in the yarn.lock file Details in greenkeeperio/greenkeeper-lockfile#85 This commit updates the yarn.lock file to contain the caret
feedmypixel
added a commit
to uktrade/data-hub-frontend
that referenced
this issue
Jan 3, 2018
What should be "get-form-data@^2.0.0:" in yarn.lock ends up being "get-form-data@2.0.0:". Essentially the prefix gets stripped when the dependancy gets updated by greenkeeper in the yarn.lock file Details in greenkeeperio/greenkeeper-lockfile#85 This commit updates the yarn.lock file to contain the caret
feedmypixel
added a commit
to uktrade/data-hub-frontend
that referenced
this issue
Jan 3, 2018
What should be "get-form-data@^2.0.0:" in yarn.lock ends up being "get-form-data@2.0.0:". Essentially the prefix gets stripped when the dependancy gets updated by greenkeeper in the yarn.lock file Details in greenkeeperio/greenkeeper-lockfile#85 This commit updates the yarn.lock file to contain the caret
|
We created a fork which resolves this. I'm dissapointed in the amount of time it's taken to get this fixed, considering greenkeeper costs money AND there is an open PR which just doesn't get any response. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Everytime we get a PR for a dependency upgrade, our lockfile gets corrupted so that running
yarn --frozen-lockfilegives the error:We get two commits in our PR (example with a recent typescript dependency upgrade):
and
As you can see, the first commit correctly keep the dependency range (
tildein our case). While, in the second commit, the tilde is removed in theyarn.lockfile. This is what makes it corrupt.I've looked through the implementation here and it seems to boil down to the command:
Which updates
yarn.lockandpackage.json- and removes the tilde from both.greenkeeper-lockfileonly stages and commits the lockfile which causes the corruption.However, we want to maintain our version ranges, so even if it staged
package.jsontoo it wouldn't be right.It seems like if I do
yarn add -D typescript@~2.6.1(that is, put the range in the dependencies version), it works as expected.We've been using version
1.2.1of yarn, but see the same behavior in1.3.2(latest right now) and0.24.8.The text was updated successfully, but these errors were encountered: