Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PLANET-7553 Move Homepage block pattern layout into master theme #2321

Merged
merged 4 commits into from
Jul 26, 2024
Merged

PLANET-7553 Move Homepage block pattern layout into master theme #2321

merged 4 commits into from
Jul 26, 2024

Conversation

sagarsdeshmukh
Copy link
Member

Ref. https://jira.greenpeace.org/browse/PLANET-7553

The homepage block pattern layout moves to the theme from the blocks plugin

Related PR:

@sagarsdeshmukh sagarsdeshmukh requested a review from a team July 12, 2024 08:44
@sagarsdeshmukh sagarsdeshmukh self-assigned this Jul 12, 2024
@sagarsdeshmukh sagarsdeshmukh requested review from mleray, GP-Dan-Tovbein and Osong-Michael and removed request for a team July 12, 2024 08:44
@sagarsdeshmukh sagarsdeshmukh force-pushed the PLANET-7553-homepage-bk-pattern branch 2 times, most recently from 9339439 to e4f50dd Compare July 12, 2024 08:58
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 12, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at e4f50dda
e275f80 
/unhold 83875f06-76b6-443b-a069-0938e6abd729
@sagarsdeshmukh sagarsdeshmukh force-pushed the PLANET-7553-homepage-bk-pattern branch from e4f50dd to 50918bd Compare July 12, 2024 09:03
@sagarsdeshmukh sagarsdeshmukh mentioned this pull request Jul 12, 2024
Merged
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 12, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at 50918bdf
4b74d86 
/unhold 6ab5d0d7-ce76-463e-aada-0c95250ff4d4
@planet-4
Copy link
Contributor

planet-4 commented Jul 12, 2024 •
edited
Loading

Test instance is ready 🚀

🌑 tavros | admin | blocks report | CircleCI | composer-local.json

⌚ 2024.07.26 12:49:36

mardelnet
mardelnet reviewed Jul 16, 2024
View reviewed changes
Copy link
Contributor

@mardelnet mardelnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @sagarsdeshmukh
Overall looks good to me, but I left some comments/questions.

assets/src/block-templates/homepage/template.js Show resolved Hide resolved
src/Patterns/Homepage.php Outdated Show resolved Hide resolved
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 17, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at 6970dc92
6f17c9c 
/unhold 413f2a25-47fc-4812-b8d7-13b87878c170
@sagarsdeshmukh sagarsdeshmukh force-pushed the PLANET-7553-homepage-bk-pattern branch from 6970dc9 to 12d4ee0 Compare July 17, 2024 09:09
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 17, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at 12d4ee0d
c587d5e 
/unhold 08562e3e-3c54-4d31-be5a-9cef1e9580e4
mardelnet
mardelnet approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@mardelnet mardelnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @sagarsdeshmukh
It looks good to me!

GP-Dan-Tovbein
GP-Dan-Tovbein reviewed Jul 22, 2024
View reviewed changes
Copy link
Contributor

@GP-Dan-Tovbein GP-Dan-Tovbein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks god to me!
However, I've checked the Tavros instance (assigned to both PRs) and deactivated the plugin. After that, inner blocks block within Homepage are not well rendered. Do you know if is there something else to touch, or maybe wait for something else to migrate? Maybe I'm missed something else 🤔 ?

@sagarsdeshmukh
Copy link
Member Author

Code looks god to me! However, I've checked the Tavros instance (assigned to both PRs) and deactivated the plugin. After that, inner blocks block within Homepage are not well rendered. Do you know if is there something else to touch, or maybe wait for something else to migrate? Maybe I'm missed something else 🤔 ?

Thanks for spotting this issue 🙏 , It was a missing scss file. I updated the PR. please have a look.

planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 24, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at 43145485
b6e5465 
/unhold 6f4d4d8b-a078-4ea1-8cb6-f285b670c775
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 24, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at 43145485
befe1f9 
/unhold f7b883b4-c236-4494-ab0b-9ca3ed91f459
@GP-Dan-Tovbein
Copy link
Contributor

Hey Sagar! I'm still seeing wrong layout issues 🙏 . Take a look at this demo page as an example!

@sagarsdeshmukh
Copy link
Member Author

Hey Sagar! I'm still seeing wrong layout issues 🙏 . Take a look at this demo page as an example!

Just to be specific, are you pointing to the issues block pattern and GF on frontend? please confirm

planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 25, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at 05760337
3fbcd7f 
/unhold afc0d944-2eeb-4571-9c10-ab869487fe16
@sagarsdeshmukh sagarsdeshmukh force-pushed the PLANET-7553-homepage-bk-pattern branch from 0576033 to 141dcc6 Compare July 26, 2024 11:09
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 26, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at 141dcc60
8239e35 
/unhold f0448b0a-95eb-4af7-a4d8-cce062d14a77
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jul 26, 2024
@planet-4
greenpeace/planet4-master-theme#2321 at 141dcc60
d98c324 
/unhold 7a29faee-c87e-4ff1-9cb8-a94b23184886
@sagarsdeshmukh sagarsdeshmukh merged commit 73e2e29 into main Jul 26, 2024
13 checks passed
@sagarsdeshmukh sagarsdeshmukh deleted the PLANET-7553-homepage-bk-pattern branch July 26, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GP-Dan-Tovbein GP-Dan-Tovbein GP-Dan-Tovbein left review comments

@mardelnet mardelnet mardelnet approved these changes

@mleray mleray Awaiting requested review from mleray mleray was automatically assigned from greenpeace/planet-4-developers

@Osong-Michael Osong-Michael Awaiting requested review from Osong-Michael

Assignees

@sagarsdeshmukh sagarsdeshmukh

Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sagarsdeshmukh @planet-4 @GP-Dan-Tovbein @mardelnet