chore: symfony 6 support

[laurent-bientz]

If there is no reason to block symfony 6

[greg0ire]

require-dev should also change. Also, Travis no longer seems to work… I've started a PR to make tests run on GA, but I've got a weird error. Anyway, if you use Symfony 6, then you must use PHP 8, and if you do, you should switch to native enums IMO.

[greg0ire]

Pipeline switched to Github Actions, please rebase 😎

[laurent-bientz]

thanks @greg0ire and yes you're totally right, i'm a using PHP8 + Symfony 6 so I can use native Enum.

Long story short, i'm migrating a huge customer project from 5.4 LTS to 6.x (for future LTS) and before converting more than 180 Enum, custom FormTypes, normalizer and extensions, I prefer to iterate step by step ;)

[greg0ire]

Fair enough I guess… the build is broken now.

[laurent-bientz]

unable to understand what's going wrong with the tests

the error seems to be related to Symfony himself in symfony\validator\Test\ConstraintValidatorTestCase.php with a ParseError: syntax error, unexpected variable "$constraints"

maybe a specific syntax error related to php 8.0 :/

tests are ok on php 8.1:

[greg0ire]

You can change the github workflow to 8.1 or 8.2 if you want to, I'm not super interested in checking that things work on 8.0, it's no longer a supported php version (apart from security fixes)

[laurent-bientz]

seems to be a dead end because we need phpunit v9 to make it works but phpunit 9 is php 7.3+ and you still support PHP7.2

no worries, I can close, I'll work on my fork, I understand that my asking is a little weirdo.

thanks for your hard work on this helpful library that will be replaced by native PHP enum 😍

[greg0ire]

@laurent-bientz please reopen, it's not a dead end: you can require PHP 8 or 9, just like here: https://github.com/doctrine/orm/blob/2.15.x/composer.json#L46

[laurent-bientz]

I will retry later, the fact is not to use the correct version of phpunit, a part of your tests suite should use phpunit 8 if php 7.2 and another part should use phpunit 9 if php 8.1, so I don't know how to deal with that depending on the matrix in the CI.

actually the version of phpunit is fixed here

your actual tests are ok with phpunit 8.5.13 if PHP < 8 but phpunit 8.5.13 fails with PHP8+

the tests are ok with phpunit 9 and PHP8+ but fails on php 7.2

so I'm a little stuck :/

[greg0ire]

One way would be to use if, like here: https://github.com/doctrine/.github/blob/main/.github/workflows/continuous-integration.yml#L46

You define one block per phpunit version, and trigger each block conditionally based on the php version.

[laurent-bientz]

looks good @greg0ire, thanks a lot for your help !

[greg0ire]

This seems more future proof:

Suggested change

	if: "${{ matrix.php-version != '8.0' }}"
	if: "${{ startsWith(matrix.php-version, '7') }}"

[laurent-bientz]

indeed!

[greg0ire]

Suggested change

	if: "${{ matrix.php-version == '8.0' }}"
	if: "${{ ! startsWith(matrix.php-version, '7') }}"

[greg0ire]

Thanks @laurent-bientz !