Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emplace #15

Closed
springmeyer opened this issue Nov 8, 2016 · 3 comments
Closed

Emplace #15

springmeyer opened this issue Nov 8, 2016 · 3 comments

Comments

@springmeyer
Copy link

I noticed that emplace functionality is disabled (https://github.com/greg7mdp/sparsepp/blob/master/sparsepp.h#L4551-L4563). Any plans to re-enable this functionality? My motivation in asking is to be able to try sparsepp in place of std::unorded_map in C++11 code that is using emplace.
greg7mdp added a commit that referenced this issue Nov 8, 2016
@greg7mdp
add support for emplace() - issue #15
1346fe2
@greg7mdp
Copy link
Owner

greg7mdp commented Nov 8, 2016

Hey Dane, thanks for using sparsepp. Just added support for emplace(). Please let me know if you have any further issue.

@greg7mdp greg7mdp closed this as completed Nov 8, 2016
@springmeyer
Copy link
Author

Thank you @greg7mdp! I'll plan to test again and will file a new issue if I hit any problems.

@springmeyer
Copy link
Author

Tested things out. Now hitting a problem with noncopyable objects. Created an issue at #16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@springmeyer @greg7mdp