-
-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add svgAttribute option #87
Milestone
Comments
Seems like a pretty solution to the problem i was having. +1 |
Hello ! I am working on it :) I'll will do a Pull Request very soon (in maybe one hour), but I'm new in Open Source project so i am searching best practices for making very clear pull request, issues... |
marques-kevin
added a commit
to marques-kevin/svgr
that referenced
this issue
May 22, 2018
marques-kevin
added a commit
to marques-kevin/svgr
that referenced
this issue
May 22, 2018
marques-kevin
pushed a commit
to marques-kevin/svgr
that referenced
this issue
May 22, 2018
marques-kevin
added a commit
to marques-kevin/svgr
that referenced
this issue
May 23, 2018
marques-kevin
added a commit
to marques-kevin/svgr
that referenced
this issue
May 23, 2018
gregberge
pushed a commit
that referenced
this issue
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Users need to add default attribute to their SVG, like in #82. My proposition is to add a "svgAttribute" option.
Usage in CLI
At first, all attribute values will be considered as a string
Usage in Node / Webpack
The text was updated successfully, but these errors were encountered: