Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Mask & Image on React Native #202

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

kimak
Copy link
Contributor

@kimak kimak commented Oct 5, 2018

Summary

New version of react-native-svg support Mask & Image:
https://github.com/react-native-community/react-native-svg/blob/master/index.js

Test plan

  • yarn build
  • yarn test --watchAll

@vercel
Copy link

vercel bot commented Oct 5, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Oct 5, 2018

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files          24       24           
  Lines         519      519           
  Branches      103      103           
=======================================
  Hits          445      445           
  Misses         66       66           
  Partials        8        8
Impacted Files Coverage Δ
packages/core/src/h2x/toReactNative.js 64.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6772d7...3853d18. Read the comment docs.

@gregberge gregberge merged commit 0256bc0 into gregberge:master Oct 5, 2018
@gregberge
Copy link
Owner

Hey @kimak! Thanks for this ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants