Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead dependency snake-case #938

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove dead dependency snake-case #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"commander": "^9.4.1",
"dashify": "^2.0.0",
"glob": "^8.0.3",
"snake-case": "^3.0.4"
"just-snake-case": "^3.2.0"
Copy link

@zettca zettca Mar 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not change-case instead?

  • It could also replace camelcase
  • It's what the author recommends (same author)
  • It's more popular (projects will more likely have change-case than just-snake-case already in their node_modules)

},
"devDependencies": {
"@types/glob": "^8.1.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/src/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import prettier from '@svgr/plugin-prettier'
import camelCase from 'camelcase'
// @ts-ignore
import dashify from 'dashify'
import { snakeCase } from 'snake-case'
import snakeCase from 'just-snake-case'

export function transformFilename(
filename: string,
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"@svgr/babel-preset": "workspace:*",
"camelcase": "^6.2.0",
"cosmiconfig": "^8.3.6",
"snake-case": "^3.0.4"
"just-snake-case": "^3.2.0"
},
"devDependencies": {
"svgo": "^3.0.2"
Expand Down
27 changes: 14 additions & 13 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.