Skip to content

Commit 092e570

Browse files
torvaldsgregkh
authored andcommitted
Disable SLUB_TINY for build testing
[ Upstream commit 6f110a5 ] ... and don't error out so hard on missing module descriptions. Before commit 6c6c1fc ("modpost: require a MODULE_DESCRIPTION()") we used to warn about missing module descriptions, but only when building with extra warnigns (ie 'W=1'). After that commit the warning became an unconditional hard error. And it turns out not all modules have been converted despite the claims to the contrary. As reported by Damian Tometzki, the slub KUnit test didn't have a module description, and apparently nobody ever really noticed. The reason nobody noticed seems to be that the slub KUnit tests get disabled by SLUB_TINY, which also ends up disabling a lot of other code, both in tests and in slub itself. And so anybody doing full build tests didn't actually see this failre. So let's disable SLUB_TINY for build-only tests, since it clearly ends up limiting build coverage. Also turn the missing module descriptions error back into a warning, but let's keep it around for non-'W=1' builds. Reported-by: Damian Tometzki <damian@riscv-rocks.de> Link: https://lore.kernel.org/all/01070196099fd059-e8463438-7b1b-4ec8-816d-173874be9966-000000@eu-central-1.amazonses.com/ Cc: Masahiro Yamada <masahiroy@kernel.org> Cc: Jeff Johnson <jeff.johnson@oss.qualcomm.com> Fixes: 6c6c1fc ("modpost: require a MODULE_DESCRIPTION()") Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 8a8f093 commit 092e570

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

mm/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ config SLAB
280280

281281
config SLUB_TINY
282282
bool "Configure SLUB for minimal memory footprint"
283-
depends on SLUB && EXPERT
283+
depends on SLUB && EXPERT && !COMPILE_TEST
284284
select SLAB_MERGE_DEFAULT
285285
help
286286
Configures the SLUB allocator in a way to achieve minimal memory

0 commit comments

Comments
 (0)