Skip to content

Commit 3858c44

Browse files
stanislavfortaislegregkh
authored andcommitted
mm/damon/sysfs: fix use-after-free in state_show()
commit 3260a3f upstream. state_show() reads kdamond->damon_ctx without holding damon_sysfs_lock. This allows a use-after-free race: CPU 0 CPU 1 ----- ----- state_show() damon_sysfs_turn_damon_on() ctx = kdamond->damon_ctx; mutex_lock(&damon_sysfs_lock); damon_destroy_ctx(kdamond->damon_ctx); kdamond->damon_ctx = NULL; mutex_unlock(&damon_sysfs_lock); damon_is_running(ctx); /* ctx is freed */ mutex_lock(&ctx->kdamond_lock); /* UAF */ (The race can also occur with damon_sysfs_kdamonds_rm_dirs() and damon_sysfs_kdamond_release(), which free or replace the context under damon_sysfs_lock.) Fix by taking damon_sysfs_lock before dereferencing the context, mirroring the locking used in pid_show(). The bug has existed since state_show() first accessed kdamond->damon_ctx. Link: https://lkml.kernel.org/r/20250905101046.2288-1-disclosure@aisle.com Fixes: a61ea56 ("mm/damon/sysfs: link DAMON for virtual address spaces monitoring") Signed-off-by: Stanislav Fort <disclosure@aisle.com> Reported-by: Stanislav Fort <disclosure@aisle.com> Reviewed-by: SeongJae Park <sj@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: SeongJae Park <sj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 591ea9c commit 3858c44

File tree

1 file changed

+9
-5
lines changed

1 file changed

+9
-5
lines changed

mm/damon/sysfs.c

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2093,14 +2093,18 @@ static ssize_t state_show(struct kobject *kobj, struct kobj_attribute *attr,
20932093
{
20942094
struct damon_sysfs_kdamond *kdamond = container_of(kobj,
20952095
struct damon_sysfs_kdamond, kobj);
2096-
struct damon_ctx *ctx = kdamond->damon_ctx;
2097-
bool running;
2096+
struct damon_ctx *ctx;
2097+
bool running = false;
20982098

2099-
if (!ctx)
2100-
running = false;
2101-
else
2099+
if (!mutex_trylock(&damon_sysfs_lock))
2100+
return -EBUSY;
2101+
2102+
ctx = kdamond->damon_ctx;
2103+
if (ctx)
21022104
running = damon_sysfs_ctx_running(ctx);
21032105

2106+
mutex_unlock(&damon_sysfs_lock);
2107+
21042108
return sysfs_emit(buf, "%s\n", running ?
21052109
damon_sysfs_cmd_strs[DAMON_SYSFS_CMD_ON] :
21062110
damon_sysfs_cmd_strs[DAMON_SYSFS_CMD_OFF]);

0 commit comments

Comments
 (0)