Skip to content

Commit 74e391f

Browse files
Quanmin Yangregkh
authored andcommitted
mm/damon/lru_sort: avoid divide-by-zero in damon_lru_sort_apply_parameters()
commit 711f19d upstream. Patch series "mm/damon: avoid divide-by-zero in DAMON module's parameters application". DAMON's RECLAIM and LRU_SORT modules perform no validation on user-configured parameters during application, which may lead to division-by-zero errors. Avoid the divide-by-zero by adding validation checks when DAMON modules attempt to apply the parameters. This patch (of 2): During the calculation of 'hot_thres' and 'cold_thres', either 'sample_interval' or 'aggr_interval' is used as the divisor, which may lead to division-by-zero errors. Fix it by directly returning -EINVAL when such a case occurs. Additionally, since 'aggr_interval' is already required to be set no smaller than 'sample_interval' in damon_set_attrs(), only the case where 'sample_interval' is zero needs to be checked. Link: https://lkml.kernel.org/r/20250827115858.1186261-2-yanquanmin1@huawei.com Fixes: 40e983c ("mm/damon: introduce DAMON-based LRU-lists Sorting") Signed-off-by: Quanmin Yan <yanquanmin1@huawei.com> Reviewed-by: SeongJae Park <sj@kernel.org> Cc: Kefeng Wang <wangkefeng.wang@huawei.com> Cc: ze zuo <zuoze1@huawei.com> Cc: <stable@vger.kernel.org> [6.0+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: SeongJae Park <sj@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 64dc351 commit 74e391f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

mm/damon/lru_sort.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,9 @@ static int damon_lru_sort_apply_parameters(void)
203203
unsigned int hot_thres, cold_thres;
204204
int err = 0;
205205

206+
if (!damon_lru_sort_mon_attrs.sample_interval)
207+
return -EINVAL;
208+
206209
err = damon_set_attrs(ctx, &damon_lru_sort_mon_attrs);
207210
if (err)
208211
return err;

0 commit comments

Comments
 (0)