Refactor polymorphism #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This sounds promising; will try it out sometime soon. Thanks! |
Conflicts: src/puget/printer.clj test/puget/printer_test.clj
|
I've started using this for normal stuff; just in case it's useful feedback, here's my method of customization: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @gfredericks fixes #13
This has a couple of changes around the polymorphism used in Puget:
TaggedValueprotocol renamed toExtendedNotation.GenericTaggedValuerecord shortened toTaggedValue.canonizedispatches ontyperather thanclassif the value does not use extended notation.This last means you can provide arbitrary print rendering for types which don't use a tagged-value representation in EDN. I originally tried making the
->ednconversion function a multimethod instead, but it didn't really work out cleanly.