Add :escape-types option #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@venantius
Tracking PR for feedback. This adds an
:escape-typesoption to Puget, which supplants the escape hatch you introduced in venantius/ultra@2fded31. I originally tried to add this feature to Whidbey, but then I realized that doesn't work well. The problem with doing this at the nrepl-middleware-level is that the escaping only happens on the top level value. Meaning, if a function returns a DatomicDBvalue, it will be escaped correctly. However, if it returns a simple data structure like a[db]then the database value is still rendered by Puget.Addresses issues like those raised in venantius/ultra#17.