Added support for Dominican-style neumes. #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems good to me, but I'm in no position to judge properly... |
|
I've run into an issue while testing. A note at |
|
As far as this change goes, I think this is ready for a final review/merge. If someone familiar with Dominican glyph usage comes forward, we can address their concerns at that time. |
|
ok for me! |
|
Hearing nothing to the contrary, I'll merge this. |
henryso
added a commit
that referenced
this pull request
Jul 11, 2015
Added support for Dominican-style neumes.
henryso
added a commit
to gregorio-project/gregorio-test
that referenced
this pull request
Jul 11, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1.
This is a bit rough, but it works. I still have a lot of testing to do before this can be merged, but please advise me if you notice anything I should do here.