Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circular dependencies #37

Closed
gfreezy opened this issue Aug 20, 2020 · 1 comment
Closed

Circular dependencies #37

gfreezy opened this issue Aug 20, 2020 · 1 comment
Assignees
@GregRos

Comments

@gfreezy
Copy link

gfreezy commented Aug 20, 2020 

(!) Circular dependencies
node_modules/parjs/internal/parser.js -> node_modules/parjs/internal/combinators/combinator.js -> node_modules/parjs/internal/scalar-converter.js -> node_modules/parjs/internal/parsers/string.js -> node_modules/parjs/internal/parser.js
node_modules/parjs/internal/parser.js -> node_modules/parjs/internal/combinators/combinator.js -> node_modules/parjs/internal/scalar-converter.js -> node_modules/parjs/internal/parsers/string.js -> /Users/feichao/Develop/log-viewer/node_modules/parjs/internal/parser.js?commonjs-proxy -> node_modules/parjs/internal/parser.js
node_modules/parjs/internal/parser.js -> node_modules/parjs/internal/combinators/combinator.js -> node_modules/parjs/internal/scalar-converter.js -> node_modules/parjs/internal/parsers/regexp.js -> node_modules/parjs/internal/parser.js
@GregRos
Copy link
Owner

GregRos commented Sep 5, 2023 •
edited
Loading

Thank you! It looks like this is caused by the implicit conversion between literals and parsers. I'll tryu to figure out a fix.

@GregRos GregRos self-assigned this Sep 6, 2023
GregRos added a commit that referenced this issue Feb 9, 2024
@GregRos
refactor: delete ScalarConverter ns, fix circular #37, simpler stack
fcdb21b
@GregRos GregRos mentioned this issue Feb 9, 2024
Merged
@GregRos GregRos closed this as completed Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregRos GregRos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfreezy @GregRos