Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shop=doityourself shop=herbalist which matches a few locations #12

Closed
wants to merge 1 commit into from

Conversation

Firefishy
Copy link

@Firefishy Firefishy commented May 4, 2021

Added:

  • shop=doityourself
  • shop=herbalist

Let me know if you'd like this linted / formatted in any particular way.

@Firefishy
Copy link
Author

@gregrs-uk 👋 Interested in this?

@gregrs-uk
Copy link
Owner

Sorry for the delay in replying, @Firefishy. I'm a teacher so tend to be busy during school terms and don't get a chance to work on projects.

These look like a sensible addition and I see there are a number of matches for both already, but I'd like to check (using a region that's already well matched) whether most of these objects tend to be registered as FHRS establishments, or only a few, so that we avoid cluttering the map and skewing the stats. I have some code for this but it may take me a little while to get round to it.

At some point I may think about some sort of two-tier system where only certain tags are assumed to (almost) always have an FHRS match, but others still appear in suggested matches and maybe on the FHRS and OSM map layers.

gregrs-uk added a commit that referenced this pull request May 19, 2021
Based on analysis of regions with at least 90% of their FHRS
establishments matched: Bath & NE Somerset, Broxtowe, Derby, Erewash,
Leeds, Wakefield. Previous tags for whom less than 50% of objects are
associated with an FHRS establishment have been removed, and those tags
for whom more than 50% of objects are associated with an FHRS
establishment have been added.

Closes #13. Related to #12.
@gregrs-uk
Copy link
Owner

Thanks for this PR. Although I'm closing it, I'm grateful for the nudge to reconsider the list of tags used for filtering the OSM data.

I've added shop=herbalist along with a lot of other tag changes in 39e1d2d. There weren't any in the well-matched regions I assessed in #13, so I'm assuming that a good proportion of the ones that do exist have a corresponding FHRS establishment.

I haven't added shop=doityourself as looking at well-matched regions, only 8 out of the 91 shop=doityourself objects were matched to FHRS establishments, and I don't want to clutter the map too much with objects unlikely to have a match.

@gregrs-uk gregrs-uk closed this May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants