Fix driver.py command line args when using ipython #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes gregsexton#63 The bug is caused when starting the client or kernel driver while having python-shell-interpreter set to ipython. The driver.py command line arguments (e.g., "--port" or "--conn-file") get parsed by ipython which doesn't recognize them and exits with an error, without starting driver.py This fix appends "--" directly after the python interpreter path, e.g., /usr/bin/ipython -- /path/to/driver.py --port 8080 This has the effect of correctly passing the driver.py command line args to driver. This change has no effect if python-shell-interpreter is python - presumably the python interpreter just ignores "--".
|
Nice. Thanks a lot for fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #63
The bug is caused when starting the client or kernel driver while having
python-shell-interpreter set to ipython. The driver.py command line
arguments (e.g., "--port" or "--conn-file") get parsed by ipython which
doesn't recognize them and exits with an error, without starting
driver.py
This fix appends "--" directly after the python interpreter path, e.g.,
/usr/bin/ipython -- /path/to/driver.py --port 8080
This has the effect of correctly passing the driver.py command line args
to driver.
This change has no effect if python-shell-interpreter is python -
presumably the python interpreter just ignores "--".