-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(formatter): generate eslint formatter-based CRC models (#41) #110
Conversation
* alphabetize options * add all [angular conventional changelog]() change types * include (most) SonarQube measures
…gregswindle/eslint-plugin-crc into feat/#13/add-bdd-test-results-circle-ci
* For (future) vunlerabilities * For contribution consistency #13
…test-results-circle-ci Feat. #13: add bdd test results circle ci
chore(package): update coveralls to version 2.13.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
</head> | ||
<body> | ||
|
||
<input type="checkbox" id="nav-trigger" class="nav-trigger" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't fix: this is an auto-generated report that would require a PR (which might not be a bad idea).
</head> | ||
<body> | ||
|
||
<input type="checkbox" id="nav-trigger" class="nav-trigger" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label
attribute.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't fix: this is an auto-generated report that would require a PR (which might not be a bad idea).
Description of change
/lib/crc
to read files from ESLintresults
file paths.CrcClasses
andCrcResponsibilities
, and add them toCrcModels
./lib/formatters/crc
to generatecrc-model-report.md
document artifacts.Associated issue(s)
Closes #41
Closes #111
Closes #113
Closes #114
Closes #115
Closes #116
Closes #117
Closes #118
Closes #119
Closes #120
Closes #125
Closes #130
Closes #132
Closes #134
PR check-list
1. Code standards compliance
ESLint
passes.2. Code quality.
Complexity
Duplications
Issues
Maintainability
Reliability
Security
3. Test coverage