Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(formatter): generate eslint formatter-based CRC models (#41) #110

Merged
merged 136 commits into from
Dec 9, 2017

Conversation

gregswindle
Copy link
Owner

@gregswindle gregswindle commented Nov 13, 2017

Description of change

  1. Use /lib/crc to read files from ESLint results file paths.
  2. Generate CrcClasses and CrcResponsibilities, and add them to CrcModels.
  3. Use /lib/formatters/crc to generate crc-model-report.md document artifacts.

Associated issue(s)

Closes #41
Closes #111
Closes #113
Closes #114
Closes #115
Closes #116
Closes #117
Closes #118
Closes #119
Closes #120
Closes #125
Closes #130
Closes #132
Closes #134

  • The acceptance criteria for all associated issues have been completed, tested, and validated.

PR check-list

✅ Please review and check the appropriate items.

1. Code standards compliance

JavaScript Style Guide

  • ESLint passes.

2. Code quality. Quality Gate

  • The quality gateways pass with an "A" grade.
Measure Scores
Complexity Complexity
Cognitive complexity
Duplications Duplications
Issues Issues
Maintainability Code smells
Maintainability
Technical debt
Reliability Reliability
Security Security

3. Test coverage Coverage Status

  • The source code is 100% covered with passing specs.

ℹ️ These tasks are not required to open a PR, and may be addresses while the PR is open.

gregswindle and others added 30 commits March 19, 2017 10:22
* alphabetize options
* add all [angular conventional changelog]() change types
* include (most) SonarQube measures
…gregswindle/eslint-plugin-crc into feat/#13/add-bdd-test-results-circle-ci
* For (future) vunlerabilities
* For contribution consistency

#13
…test-results-circle-ci

Feat. #13: add bdd test results circle ci
chore(package): update coveralls to version 2.13.0
* Upgrade eslint
* Upgrade espree
* Upgrade nyc
* Upgrade coveralls

#15, #16, #18, #19
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ff851ba on refactor/#41-rule-based-crc-models into ** on master**.

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

</head>
<body>

<input type="checkbox" id="nav-trigger" class="nav-trigger" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't fix: this is an auto-generated report that would require a PR (which might not be a bad idea).

</head>
<body>

<input type="checkbox" id="nav-trigger" class="nav-trigger" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't fix: this is an auto-generated report that would require a PR (which might not be a bad idea).

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ff851ba on refactor/#41-rule-based-crc-models into ** on master**.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ff851ba on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ff851ba on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Changes Unknown when pulling 5ce0fa6 on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Changes Unknown when pulling 5ce0fa6 on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Changes Unknown when pulling 2650739 on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Changes Unknown when pulling 0794051 on refactor/#41-rule-based-crc-models into ** on master**.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0794051 on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Changes Unknown when pulling a017db3 on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Changes Unknown when pulling 9b5d38f on refactor/#41-rule-based-crc-models into ** on master**.

@gregswindle gregswindle changed the title Refactor: generate eslint rule based crc models (#41) refactor(formatter): generate eslint formatter-based CRC models (#41) Dec 9, 2017
@coveralls
Copy link

coveralls commented Dec 9, 2017

Coverage Status

Changes Unknown when pulling 9fbc491 on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7c98083 on refactor/#41-rule-based-crc-models into ** on master**.

2 similar comments
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7c98083 on refactor/#41-rule-based-crc-models into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7c98083 on refactor/#41-rule-based-crc-models into ** on master**.

@gregswindle gregswindle merged commit 43341b5 into master Dec 9, 2017
@gregswindle gregswindle deleted the refactor/#41-rule-based-crc-models branch December 9, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants