Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init #1

Merged
merged 23 commits into from
Oct 22, 2017
Merged

Init #1

merged 23 commits into from
Oct 22, 2017

Conversation

gregurco
Copy link
Owner

@gregurco gregurco commented Oct 16, 2017

From: 8p/guzzle-wsse-middleware#13

Todo:

  • add GuzzleBundle in requirements in composer.json
  • rename GuzzleWsseBundle into GuzzleBundleWssePlugin
  • tests
  • travis build

@coveralls
Copy link

coveralls commented Oct 19, 2017

Coverage Status

Changes Unknown when pulling 64e5cdc on init into ** on master**.

@florianpreusner
Copy link

Very nice! Just a question, @gregurco: I thought you are ging to use wsse-plugin and creating the bundle around it. So the bundle only created the bridge to make it usable in guzzle bundle / symfony.

@gregurco
Copy link
Owner Author

I thought about that but in this case I had to do one more PR in wsse-plugin with many changes and to track dependency on two repos. I decided that guzzle-bundle with version <7 will use wsse-plugin but >=7 will use this repo. Just not to have many repos with 1-2 files. What do you think? What's your suggestion?

@florianpreusner
Copy link

Yeah, that's totally fine for me 👍 I mean, we are talking about 1-2 files, as you said.

@gregurco gregurco merged commit 5256d50 into master Oct 22, 2017
@gregurco gregurco deleted the init branch October 22, 2017 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants