Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling #8

Open
dominiksalvet opened this issue Apr 28, 2020 · 4 comments
Open

Error handling #8

dominiksalvet opened this issue Apr 28, 2020 · 4 comments

Comments

@dominiksalvet
Copy link

dominiksalvet commented Apr 28, 2020

It would be great to handle asus-fan-control error messages and create an error dialog for them once they occur as the output in terminal may be overlooked (and in the future, afc-gui may run as an application without any terminal at all). Note that all error messages are written to a standard error stream so it may be possible to catch this stream in the afc-gui somehow and process it there.

E.g., trying to set custom temps with invalid temperatures in the text entry.

@Greifent
Copy link
Owner

I understood the problem, I hadn't considered it thought, the terminal output it is done automatically by the subprocess function, I just need to create another dialog screen.

@Greifent
Copy link
Owner

Thank for the int

@Greifent
Copy link
Owner

Greifent commented Jul 3, 2020

Hi, I've figured out a way to return an error if the program cannot execute an asus-fan-control command; I'm still looking on how to do the temperature check.

@Greifent
Copy link
Owner

Hi, I've recently started working on this project again, I'm testing a check to see that temperatures are valid, and a error window popup to let the user know of the error. I'll keep you updated on the development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants