-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to show marks instead of title #532
Conversation
b90548a
to
17c31cd
Compare
@ammgws Something to consider: I only use 1 mark per window, but sway lets you have several marks per window if you do Also some interesting info from the man page:
I'm not sure if i3status-rust should hide underscores. Marks are not shown by default and there might be unforeseen side effects. |
I can look into the multiple marks thing and an option to hide the underscored ones. However if the i3ipc crate is updated before that then we can just merge this simple implementation now and add those features later. |
…indow block, and a sway driver for the keyboard_layout block. sway IPC is built on top of i3 IPC, so anything that works in i3 also works in sway. However with this crate we can access sway-only parts of the IPC such as the keyboard layout. Also, the maintainer for i3ipc-rs seems to be AWOL at the moment which is stalling greshake#532
This allows future work such as adding marks support to the focused_window block, and a sway driver for the keyboard_layout block. sway IPC is built on top of i3 IPC, so anything that works in i3 also works in sway. However with this crate we can access sway-only parts of the IPC such as the keyboard layout. Also, the maintainer for i3ipc-rs seems to be AWOL at the moment which is stalling greshake#532
@travankor this is now implemented using the swayipc-rs crate. It works fine for me, please let me know if there are any issues. |
So with one mark set, e.g. "abc", the bar should display: "abc" And with multiple marks set, e.g. "abc" and "def", the bar should display: "[abc] [def]" ? If the binary size is a problem then I will have to look into later. Perhaps enabling LTO could help. Do you mean last release as in the last tagged version vs git master? |
Yes. It's not a problem for me personally; I just noticed this and wanted to report it. |
FYI enabling link time optimizations brings it down to 8.6MB |
This can be merged once tmerr/i3ipc-rs/pull/51 has been implemented.
Solves #486