Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the serial port's logger for RTU connections #31

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

andig
Copy link
Contributor

@andig andig commented Aug 26, 2020

While the tcpclient's tcpTransporter exposes a logger, the rtuclient's rtuSerialTransporter embeds a private serialPort which has a logger but isn't externally accessible. This PR exposes the serial ports logger through the handler similar to the tcpTransporter.

@andig
Copy link
Contributor Author

andig commented Aug 27, 2020

Noticed this when being unable to debug a serial connection issue in a bigger application. The change is backwards-compatible as the Logger field didn‘t exist before and the serial‘s logger was sealed away from access.

@guelfey guelfey requested review from frzifus and gq0 August 27, 2020 07:15
Copy link
Member

@guelfey guelfey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, up to @gq0 and @frzifus

@frzifus frzifus added the enhancement New feature or request label Aug 28, 2020
@andig
Copy link
Contributor Author

andig commented Aug 28, 2020

Thanks @frzifus for the assignment but I'm afraid there's not much more I can do right now ;)

Copy link
Contributor

@gq0 gq0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gq0 gq0 merged commit cb26bc3 into grid-x:master Aug 31, 2020
@andig andig deleted the fix/logger branch August 31, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants