Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vendor): migrate from glide to go modules #35

Merged
merged 1 commit into from
Jan 12, 2021

Conversation

frzifus
Copy link
Contributor

@frzifus frzifus commented Dec 23, 2020

No description provided.

@frzifus frzifus added the enhancement New feature or request label Dec 23, 2020
@frzifus frzifus self-assigned this Dec 23, 2020
@andig
Copy link
Contributor

andig commented Dec 29, 2020

Yes please! I would not set go 1.15 as required though, if I remember the discussion the highest required is 1.13 or lower?

@andig
Copy link
Contributor

andig commented Dec 29, 2020

See #23. Lowest version was 1.11.

@andig
Copy link
Contributor

andig commented Jan 12, 2021

Ping @gq0 @frzifus any chance to move this forward?

Only potential change I'd see is the required version though anybody using go will probably mostly be on lastest anyway.

@frzifus
Copy link
Contributor Author

frzifus commented Jan 12, 2021

i guess with the default values 1.13 was needed. so i changed it to that. :)

@frzifus frzifus requested a review from Carelo January 12, 2021 14:22
Copy link
Contributor

@Carelo Carelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frzifus frzifus merged commit ab35ea4 into grid-x:master Jan 12, 2021
@frzifus frzifus deleted the feat/switch_to_gomod branch January 12, 2021 16:41
@gq0
Copy link
Contributor

gq0 commented Jan 12, 2021

Wasn't it that with version 1.13 go modules language features are active by default? I guess if you want to support a version prior you have to set some flags/environment variables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants