Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use time.Since #57

Merged
merged 3 commits into from
Nov 9, 2022
Merged

Use time.Since #57

merged 3 commits into from
Nov 9, 2022

Conversation

andig
Copy link
Contributor

@andig andig commented Nov 6, 2022 •
edited
Loading

Available on Go 1.13

@andig
Copy link
Contributor Author

andig commented Nov 6, 2022 •
edited
Loading

@frzifus I've pushed one more commit to make the implementations consistent. Thanks for the quick review!

frzifus
frzifus approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @guelfey @Rania-Zoghlami

guelfey
guelfey approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@guelfey guelfey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@guelfey guelfey merged commit 6bf5f3b into grid-x:master Nov 9, 2022
@andig andig deleted the fix/since branch November 9, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guelfey guelfey guelfey approved these changes

@frzifus frzifus frzifus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andig @guelfey @frzifus