Space time by extrusion #801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #801 +/- ##
==========================================
+ Coverage 88.24% 88.50% +0.25%
==========================================
Files 158 162 +4
Lines 17651 18131 +480
==========================================
+ Hits 15577 16047 +470
- Misses 2074 2084 +10
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Edit the NEWS.md file, please |
amartinhuertas
requested changes
Jun 21, 2022
There was a problem hiding this comment.
@amartinhuertas can you take a look?
@santiagobadia, thanks for your work! I have added a set of (mostly) minor comments.
|
Hi @santiagobadia ! FYI ... The tests failed https://github.com/gridap/Gridap.jl/runs/7066471889?check_suite_focus=true#step:6:285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have implemented some models with a FE space to describe the geo_map.
@amartinhuertas can you take a look?