added lastindex for MultiValue and tests
#834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kishore-nori! Thanks for the PR. Do not forget to add an entry to the NEWS.md file. You will have to add an unreleased section, as in here https://github.com/gridap/Gridap.jl/blob/f7be57ee6ef4169932b211adc440210bf65864d7/NEWS.md#unreleased |
|
May you please add another entry to the NEWS.md file, section "added", that tells that we added BDM RefFEs in PR #823 ? We forgot to do this in a previous PR. Thanks! |
Antoinemarteau
pushed a commit
to Antoinemarteau/Gridap.jl
that referenced
this pull request
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @amartinhuertas and @fverdugo, I have added the
lastindexmethod forMultiValuefor using[end]and to resolve ambiguity withlengthupon discussion with @amartinhuertas, as currentlylastindexfalls back toNumber, returning 1, which is not consistent withlengthfor the same argument, the above is a small fix for the same usinglengthunder the hood.