Block assemblers #915
Merged
Block assemblers #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BlockMatrixAssemblers now is an Assembler, not a SparseMatrixAssembler. - It does not depend on the SparseMatrixAssembler interface, thus can be used with any assembler. This is in preparation for Distributed block assemblers.
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #915 +/- ##
==========================================
+ Coverage 87.89% 88.00% +0.11%
==========================================
Files 173 174 +1
Lines 20401 20626 +225
==========================================
+ Hits 17931 18152 +221
- Misses 2470 2474 +4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
…lock-assemblers-docs
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements block assemblers, which allow to assemble a
MultiFieldFESpaceblock-wise.Instead of a sparse monolithic matrix and vectors, this assembler leverages BlockArrays.jl to produce equivalent block-partitioned sparse matrices and vectors. This is meant to ease the development of block preconditioners and solvers.
Main features:
MultiFieldStyle, calledBlockMultiFieldStylethat allows then user to control which field is assembled in which block, the number of blocks, etc...BlockSparseMatrixAssembler, which implements theSparseMatrixAssemblerinterface.TODO:
ArrayBlockViewtosrc/Fields/ArrayBlocks.jl.IMPORTANT: This PR should not be merged yet. This is open for comments, and waiting for the parallel implementation to be finalized in GridapDistributed.
NOTE: After merging this, we should remember to also delete the branch
rethinking-block-assemblers.