Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document guc/dcpriv behaviour with servers not supporting DC encryption #100

Merged
merged 2 commits into from
Jul 26, 2019

Conversation

fscheiner
Copy link
Member

Until we find a way to "fix" the problem described in #62 w/o breaking other functionality in the GridFTP server and client(s) this PR puts a warning into the guc manpage which - together with the apparently known fact (as per #69) that dCache does not support data channel encryption - hopefully prevents user from falling into that trap.


@ellert

  • I changed the text version of the manpage and the manpage directly, is there a tool I could use instead?
  • Does this change also require a version number change for the gass-copy packages (in the spec and debian packaging files)? I'd say yes, but am unsure. If you agree, I can add these changes to this PR.

@fscheiner
Copy link
Member Author

If accepted, I will also update the documentation in https://github.com/gridcf/gct-docs.

@ellert
Copy link
Member

ellert commented Jul 25, 2019

@ellert

  • I changed the text version of the manpage and the manpage directly, is there a tool I could use instead?

  • Does this change also require a version number change for the gass-copy packages (in the spec and debian packaging files)? I'd say yes, but am unsure. If you agree, I can add these changes to this PR.

The rules to generate the man pages from the text sources are in the Makefiles. If configure is run with a2x or a2x.py installed the rules will be activated and you can jusr run "make globus-url-copy.1". a2x is provided by the asciidoc package.

See configure.ac and Makefile.am for details.

Yes, the version should be bumped.

@fscheiner
Copy link
Member Author

@ellert
The rules to generate the man pages from the text sources are in the Makefiles. If configure is run with a2x or a2x.py installed the rules will be activated and you can jusr run "make globus-url-copy.1". a2x is provided by the asciidoc package.

See configure.ac and Makefile.am for details.

Thanks for the clarification.

Yes, the version should be bumped.

Ok, will do so.

@fscheiner
Copy link
Member Author

Took me a while to get everything to work on Armbian Stretch (based on Debian Stretch). Maybe useful for documentation: in addition to build-essential (although this might be a little overkill) one needs to install the following packages:

asciidoc libtool libltdl-devpkg-config docbook-xml docbook-xsl xsltproc

...to make this work.


BTW, that (autoreconf -i && ./configure) is a considerable effort for just changing a manpage. Why do we actually keep the resulting manpages in the repo if they're (re)created during a make run anyhow?

@fscheiner
Copy link
Member Author

Nearly forgot to ask: Is the version bump ok as is (10.4 to 10.5), or should I just bump the release (10.4-1 to 10.4-2)?

@ellert
Copy link
Member

ellert commented Jul 26, 2019

Nearly forgot to ask: Is the version bump ok as is (10.4 to 10.5), or should I just bump the release (10.4-1 to 10.4-2)?

You have done it correctly. This changes files that are in the source tarball, so the tarball name must change (globus_gass_copy-10.4.tar.gz → globus_gass_copy-10.5.tar.gz). Bumping the release keeping the version is for making a package update using the same source tarball, possibly adding patches to the source package.

@fscheiner fscheiner merged commit 6c76874 into gridcf:master Jul 26, 2019
fscheiner added a commit to fscheiner/gct-docs that referenced this pull request Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants