Packaging cleanup #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 29, 2018
matyasselmeci
approved these changes
Mar 29, 2018
| --libexecdir=%{_datadir}/globus \ | ||
| --docdir=%{_pkgdocdir} \ | ||
| --with-perlmoduledir=%{perl_vendorlib} \ | ||
| --with-backward-compatibility-hack |
There was a problem hiding this comment.
Do you know what --with-backward-compatibility-hack does? Can we drop it?
There was a problem hiding this comment.
This was introduced when the flavours were dropped. (You remember the flavour mess with libglobus_common_gcc32 vs. libglobus_common_gcc32pthr?). The dropping of the flavours meant a backward incompatibility. By introducing versioned symbols old binaries linked against the old library still worked with the new library.
Dropping --with-backward-compatibility-hack would remove some symbols from the globus-common library, which would mean that a soname bump would be necessary. We do not want to do that.
ellert
force-pushed
the
packaging-cleanup
branch
from
a252489
to
81f1b47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to the packaging files based on the Fedora and Debian packages.