-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question - MPLPostStep fails #58
Comments
the pipeline works fine if i remove the MPLPostStep |
Hi @RamchandV , Could you please describe the steps to reproduce, because right now it's hard to get what did you changed in the pipeline (if you changed anything). In the default MPL modules we using Thank you |
That's the weird part i did not change anything and it still fails. I'm thinking to use your your new merge as is and see whats happening. Is there any examples other than what you have here ? |
Unfortunately release Right now what we have the next examples:
Thank you |
I did not change anything , running your code as is , this is the error i get
JenkinsFile Config
|
@RamchandV , I asked you before to describe the steps to reproduce - probably you missed the important things:
First of all - try to build the MPL itself, how it's built by CircleCI, than you can go to modifications (use some |
@sparshev Sorry below is a detailed description. One more thing i noticed when you see my first description the body the call gets is null is that expected?
Configuration my branch test is your current master and i'm using it unchanged . changes made only in the JenkinsFile to enable deploy stage. How i enabled the project
|
Ok, @RamchandV - I just tested the latest MPL master in all possible ways with the LTS jenkins and quite fresh plugins:
And it's working well - both with default and your way modified Jenkinsfile (although I used master instead of linux): About the exception you see: And again - please try to build the MPL itself (with no modifications anywhere) to check your jenkins is ok. But most probably you have a wrongly modified version of some MPL logic - that's why you see this issue.
What do you mean? It's getting 2 values: |
I had to make the below change to make it work , it did not make sense for me , let me know if you think otherwise Just added the decorator
|
@RamchandV , did you made the default mpl build work on your jenkins? It's working fine? Could I close this question ticket? Regarding the change - there is no need in Thank you |
I was not able to make the default pipeline run , only after i made this changes it started to work for me. |
@RamchandV , you mean "you saw the exception ends up with If you trying to make this statement - it for sure makes no sense for me right now (I already described what kind of issue could cause such exception). Probably I missing something, so:
But for now - it looks for me like not reproducible issue on your side. I can't reproduce the issue and confirm your statement about |
yes adding @NonCPS fixed mine , i was also thinking jenkins ENV is different. Let me see if i can setup a clean Jenkins and test this |
@sparshev @NonCPS is also work for me. My nested library demo is based on mpl.wiki's repo.
And my app project's jenkinsfile is like below
|
@Cheava , the question right now - how to reproduce the issue. About your logic: Probably it's the way to reproduce the issue, need to check it. |
Hi @Cheava , I tried to reproduce the issue in the ticket using the same call So hopefully someone can provide some strict steps to reproduce - but right now this ticket looks like unable to reproduce for me. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi All. So I am using a nested library and calling official library like this: MPLInit.groovy Should I use mpl@master instead? |
@rolando-lorenzo right, master branch is the preffered one and most stable with latest features and working on the latest jenkins well. |
@sparshev thank you :) |
I have just been able to reproduce this issue, with the following pipeline
Jenkins: 2.190.3 Output:
|
Hi @Napo2k , sure will check that tomorrow morning. Could you please describe - it's necessary to use agent |
The Test module is simply |
Exact same issue when running on the master agent |
@Napo2k I did a couple of tests with your proposed Jenkinsfile and looks like the actual issue is not related to The minimal reproducible logic is:
For sure this is a bug - will check how to properly fix it. |
I had the same problem with an older version of Jenkins (2.235.1), and after updating Jenkins (2.235.3) the issue was resolved |
Below is the POST checkout step i modified , if this runs all i see is the below error
java.util.NoSuchElementException: Cannot access last() element from an empty List
i even added some displays this is what i see , body comes in null is that expected ?
The text was updated successfully, but these errors were encountered: