-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement shared credentials across gridscale tools (#136) #153
Implement shared credentials across gridscale tools (#136) #153
Conversation
@JanLukasGithub this is gonna be a breaking change. |
That's why I asked
And yes this should only be pulled for the next major release (The issue has milestone v0.12.0) |
Yep, a migration will be needed for the new config. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK from my side. Wouldn't bother much with automatically moving the old config to the new gridscale/config.yaml path, but it's fine. What is missing is a good Changelog entry. So that users can immediately see the change and act accordingly. Updating the binary is an active step anyway.
Should I put the changelog as v0.11.1 or as v0.12.0? I think v0.12.0 is more adequate for the amount and impact of the changes |
@JanLukasGithub Agree, v0.12.0 makes more sense. |
Looks great! Everything looks ready from my side |
Before it was /gscloud/config.yaml, now it's /gridscale/config.yaml
Priority is GRIDSCALE_PROJECT < --account < --project
Don't print the deprecation warning when the command doesn't require the config
Rebased |
Picked into master branch |
/gscloud/config.yaml
to/gridscale/config.yaml
andto
as proposed in #136
Changes the name of
--account
flag andGRIDSCALE_ACCOUNT
environment variable to--project
andGRIDSCALE_PROJECT
respectively for consistency reasonsThere will be no compatibility to
GRIDSCALE_ACCOUNT
as it wasn't part of the last release, but--account
will still be usable, though deprecated and lower priority than--project
The old config path/contents can still be loaded, but the user will be warned of deprecation
gscloud move-config
will be introduced. copying and converting the old config to the new one