-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested grid looses verticalMargin setting when parent grid item moved (inherits parent setting) #726
Comments
@kool-kat I believe there's an existing ticket that mentions this. If I can find the ticket, I'll mention the link here and close this ticket. If not, I'll keep this open. Thanks again for logging all of these bugs - if we're unaware of the issues, we can't make the fixes. |
I tried latest code and modified nested.html and still happens when moving, even with fix for #425 to have copy of the options per grid. |
* complete re-write how we size/position items dealing with margin * we now have a single `margin` grid option which will set all 4 sides instead of one in code nad one in CSS * also have `marginTop/Bottom/Left/Right` if more precise setting is required * greatly reduced the layout code as margin are now inside the grid-item (affects content) * fixed code so `cellHeight: 'auto'` (now the default) will create real square cells (used to be off due to margin) * grid will now have consistant spacing (above/below first/last rows)
I have a nested grid with its own verticalMargin setting, which differs to the parent (wrapper) grid.
Moving a parent grid widget results in the nested grid being redrawn with the parent margin setting not its own.
Movie showing this is attached.
nestedloosemargin.zip
My grid code:
My function and options:
The text was updated successfully, but these errors were encountered: