Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes #59 #66

Merged
merged 1 commit into from
Dec 16, 2019
Merged

closes #59 #66

merged 1 commit into from
Dec 16, 2019

Conversation

ahwagner
Copy link
Member

In this PR:

  • Messages to assist users in getting desired behavior on failed load_cache.
  • Prevent clobbering of in-memory cache on failed load_cache.
  • Prevent overwrite of local cache on failed load_cache or failed update_cache.

@ahwagner ahwagner mentioned this pull request Dec 16, 2019
Closed
@ahwagner
Copy link
Member Author

This PR has no corresponding tests, which would require mocking or a test service. Due to time constraints, this is okay, but opened #67 for me or @susannasiebert to address in near term.

susannasiebert
susannasiebert approved these changes Dec 16, 2019
View reviewed changes
Copy link
Collaborator

@susannasiebert susannasiebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ahwagner ahwagner merged commit 5395aa2 into master Dec 16, 2019
@susannasiebert susannasiebert deleted the issue-59 branch February 5, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susannasiebert susannasiebert susannasiebert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahwagner @susannasiebert