repair urllib3 can't set timeout! (SeleniumHQ#6286)

cls._timeout should be transfer to request when init urllib3.PoolManager
grigaman · Sep 20, 2018 · 26e4d57 · 26e4d57
1 parent 2ddb978
commit 26e4d57
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/py/selenium/webdriver/remote/remote_connection.py b/py/selenium/webdriver/remote/remote_connection.py
@@ -137,7 +137,7 @@ def __init__(self, remote_server_addr, keep_alive=False, resolve_ip=True):
 
         self._url = remote_server_addr
         if keep_alive:
-            self._conn = urllib3.PoolManager()
+            self._conn = urllib3.PoolManager(timeout=self._timeout)
 
         self._commands = {
             Command.STATUS: ('GET', '/status'),
@@ -398,7 +398,7 @@ def _request(self, method, url, body=None):
 
             statuscode = resp.status
         else:
-            http = urllib3.PoolManager()
+            http = urllib3.PoolManager(timeout=self._timeout)
             resp = http.request(method, url, body=body, headers=headers)
 
             statuscode = resp.status