Added typing_extensions to dependencies. #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @awvwgk possible to merge and fix? Thx :) |
|
Thanks for the patch. However since the CI is not passing it is hard to merge |
|
Indeed! However the CI is failing for reasons unrelated to the patch. Is CI passing on master branch? I.e., have you fixed these build issues already? If so I'll rebase and push. |
At least with meson 1.3.2 one has to set pure to false for find installation or else build fails. Signed-off-by: Howard Pritchard <howardp@lanl.gov>
…s check for third party dependency package. This dependency is correctly specified in pyproject.toml. (grimme-lab#109)
|
Rebased off latest changes from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #111
Changelog description
Added
typing_extensionsto dependencies.Status
Good to go!