Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandwich Potential #930

Merged
merged 12 commits into from
Feb 19, 2024
Merged

Sandwich Potential #930

merged 12 commits into from
Feb 19, 2024

Conversation

demonic-daisy
Copy link
Contributor

Sandwich potential for xtb. Use alongside spherical and ellipsoid constraining potential. Only logfermi available.

*sandwich*: auto|'real',all|'list',...::
set up a sandwich wall potential for all or the atoms in 'list'
with the radius 'real' or an automatical determined sandwich radius in Bohr
Always use sandwich potential together with $cma keyword!!!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better to switch on the center of mass mode automatically

Copy link
Member

@MtoLStoN MtoLStoN Feb 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, this is already done here, so the keyword should not be needed? nvm, that does not seem to work as expected

xtb/src/constrain_param.f90

Lines 1083 to 1090 in cbb50a7

case('sandwich')
if (narg.lt.2) then
call env%error("Not enough arguments to set up sandwich walls",source)
return
endif
! part 1: get the sandwich distance
wpot%sandwich = .true.
set%do_cma_trafo = .true.

MtoLStoN
MtoLStoN previously approved these changes Feb 15, 2024
@MtoLStoN MtoLStoN dismissed their stale review February 15, 2024 15:25

cma needs a second look

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
@MtoLStoN
Copy link
Member

The cma constraint should now be automatically activated when using a sandwich potential. LGTM now.

@Albkat Albkat merged commit 69aead6 into grimme-lab:main Feb 19, 2024
11 checks passed
gorges97 pushed a commit to gorges97/xtb that referenced this pull request Mar 27, 2024
* sandwich potential somehow works for optimizations. next: it doesnt work for aISS.

* sandwich pot somehow works for sp and opt but not MD or docking.

* sandwich pot somehow works for sp and opt but not MD or docking. zwischenspeicherung.

* sandwich pot works for MD but not for aISS.

* sandwich pot works for MD and aISS (compiler problem with gcc/gfortran). Next: extend subroutine all to frag and list.

* extended subroutine sandwich_all to frag and list; plus error handling.

* updated xcontrol page by sandwich potential options

* Update xcontrol.7.adoc

* Delete subprojects/json-fortran-8.2.5.wrap

* Clean up dev files.

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>

* Allow automated activation of cma for sandwich pot

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>

---------

Signed-off-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
Co-authored-by: albert <92109627+Albkat@users.noreply.github.com>
Co-authored-by: MtoLStoN <70513124+MtoLStoN@users.noreply.github.com>
Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants