Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix preprocessor definitions #946

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix preprocessor definitions #946

merged 1 commit into from
Jan 10, 2024

Conversation

Albkat
Copy link
Contributor

@Albkat Albkat commented Jan 9, 2024

For the CMake build:

  1. Enable the building of an object library for CMake versions newer than 3.28.0.
  2. Allow compilation with preprocessor definitions.

For the Meson build:

  1. Enable preprocessor definitions in the main.f90 .

@Albkat
fix preprocessor definitions
91839f8 
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
@Albkat Albkat added the build Build system related issues (OS, compilers, meson) label Jan 9, 2024
@Albkat Albkat merged commit 0fb151d into grimme-lab:main Jan 10, 2024
11 checks passed
@Albkat Albkat deleted the cmake_tblite branch January 10, 2024 07:21
gorges97 pushed a commit to gorges97/xtb that referenced this pull request Mar 27, 2024
@Albkat @gorges97
fix preprocessor definitions (grimme-lab#946)
3ad64c0 
Signed-off-by: albert <92109627+Albkat@users.noreply.github.com>
Signed-off-by: Johannes Gorges <58849467+gorges97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

@marcelmbn marcelmbn Awaiting requested review from marcelmbn

@MtoLStoN MtoLStoN Awaiting requested review from MtoLStoN

Assignees
No one assigned
Labels
build Build system related issues (OS, compilers, meson)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Albkat @awvwgk